[Backport 8.0] [IIS] Manually parse exe bitness (#61894) #62037
Merged
+63
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrennanConroy
added
the
Servicing-consider
BrennanConroy
added
area-networking
danmoseley
approved these changes
May 21, 2025
dotnet-policy-service
bot
added
the
pending-ci-rerun
|
/azp run |
wtgodbe
removed
the
pending-ci-rerun
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Jul 21, 2025
Open
This was referenced Jul 22, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #61894
[IIS] Manually parse exe bitness
Description
In the AspNetCoreModule for IIS we have a check that dotnet.exe is the same architecture as the worker process (w3wp.exe). We used the windows function
GetBinaryTypeWto determine this information, which while correct has raised some concerns since it loads the exe into executable space.This PR changes the code to manually parse the exe file headers which is a well known format and use that information for the bitness check. This avoids loading the exe in executable space and still lets us check that the bitness matches.
Customer Impact
We unnecessarily load the specified exe into executable space.
Regression?
Risk
Updating a non-critical check, so if it checks incorrectly it will only result in slightly worse program diagnosability on app run failure. Also did a bunch of testing on the code to make sure it shouldn't be possible to throw which would be problematic.
Verification
Packaging changes reviewed?